chaoyli commented on a change in pull request #563: Modify schema change to use
rowset
URL: https://github.com/apache/incubator-doris/pull/563#discussion_r250467924
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -2347,56 +2213,26 @@ OLAPStatus SchemaChange::create_initial_rowset(
SchemaHash schema_hash,
Version version,
VersionHash version_hash,
- SegmentGroup* segment_group) {
+ RowsetBuilderSharedPtr rowset_builder) {
VLOG(3) << "begin to create init version. "
<< "begin=" << version.first << ", end=" << version.second;
- TabletSharedPtr tablet;
- ColumnDataWriter* writer = NULL;
OLAPStatus res = OLAP_SUCCESS;
do {
if (version.first > version.second) {
- OLAP_LOG_WARNING("begin should not larger than end. [begin=%d
end=%d]",
- version.first, version.second);
+ LOG(WARNING) << "begin should not larger than end. "
+ << " [begin=" << version.first
Review comment:
bracket is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
