chaoyli commented on a change in pull request #563: Modify schema change to use rowset URL: https://github.com/apache/incubator-doris/pull/563#discussion_r250466397
########## File path: be/src/olap/schema_change.cpp ########## @@ -1115,121 +1057,109 @@ bool SchemaChangeWithSorting::process(ColumnData* olap_data, SegmentGroup* new_s } bool SchemaChangeWithSorting::_internal_sorting(const vector<RowBlock*>& row_block_arr, - const Version& temp_delta_versions, - SegmentGroup** temp_segment_group) { - ColumnDataWriter* writer = NULL; + const Version& version, + const VersionHash version_hash, + RowsetSharedPtr* rowset) { uint64_t merged_rows = 0; RowBlockMerger merger(_tablet); - (*temp_segment_group) = - new(nothrow) SegmentGroup(_tablet->tablet_id(), - 0, - _tablet->tablet_schema(), - _tablet->num_key_fields(), - _tablet->num_short_key_fields(), - _tablet->num_rows_per_row_block(), - _tablet->rowset_path_prefix(), - temp_delta_versions, - rand(), - false, - 0, 0); - if (NULL == (*temp_segment_group)) { - OLAP_LOG_WARNING("failed to malloc SegmentGroup. [size=%ld]", sizeof(SegmentGroup)); - goto INTERNAL_SORTING_ERR; + RowsetBuilderContextBuilderSharedPtr context_builder(new RowsetBuilderContextBuilder()); Review comment: RowsetBuilderContextBuilderSharedPtr -> RowsetWriterContextBuilderSharedPtr ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org