chaoyli commented on a change in pull request #563: Modify schema change to use
rowset
URL: https://github.com/apache/incubator-doris/pull/563#discussion_r250472139
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -843,52 +795,42 @@ bool SchemaChangeDirectly::process(ColumnData*
olap_data, SegmentGroup* new_segm
}
add_filted_rows(filted_rows);
- if (!_write_row_block(writer, new_row_block)) {
+ if (!_write_row_block(rowset_builder, new_row_block)) {
OLAP_LOG_WARNING("failed to write row block.");
result = false;
goto DIRECTLY_PROCESS_ERR;
}
- olap_data->get_next_row_block(&ref_row_block);
-
- }
+ rowset_reader->next_block(&ref_row_block);
- if (OLAP_SUCCESS != writer->finalize()) {
- result = false;
- goto DIRECTLY_PROCESS_ERR;
}
- if (OLAP_SUCCESS != new_segment_group->load()) {
Review comment:
where to load rowset?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
