imay commented on a change in pull request #246: Colocate Join (#245)
URL: https://github.com/apache/incubator-doris/pull/246#discussion_r234484894
##########
File path: fe/src/main/java/org/apache/doris/planner/OlapScanNode.java
##########
@@ -565,12 +576,20 @@ private void getScanRangeLocations(Analyzer analyzer)
throws UserException, Anal
List<Tablet> tablets = new ArrayList<Tablet>();
Collection<Long> tabletIds = distributionPrune(selectedTable,
partition.getDistributionInfo());
LOG.debug("distribution prune tablets: {}", tabletIds);
+
+ List<Long> allTabletIds = selectedTable.getTabletIdsInOrder();
if (tabletIds != null) {
for (Long id : tabletIds) {
tablets.add(selectedTable.getTablet(id));
+
+ tabletId2BucketSeq.put(id, allTabletIds.indexOf(id));
Review comment:
Call `indexOf` for every tablet is inefficient, can you improve this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
