imay commented on a change in pull request #246: Colocate Join (#245)
URL: https://github.com/apache/incubator-doris/pull/246#discussion_r231438618
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -4542,6 +4722,34 @@ public void replayRenameTable(TableInfo tableInfo)
throws DdlException {
}
}
+ //the invoker should keep db write lock
+ public void modifyTableColocate(Database db, OlapTable table, String
colocateTable) throws DdlException {
Review comment:
1. db lock is not locked
2. why colocate condition is not check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
