imay commented on a change in pull request #246: Colocate Join (#245)
URL: https://github.com/apache/incubator-doris/pull/246#discussion_r231433443
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -3334,7 +3428,14 @@ private Table createOlapTable(Database db,
CreateTableStmt stmt, boolean isResto
// just for remove entries in stmt.getProperties(),
// and then check if there still has unknown properties
PropertyAnalyzer.analyzeDataProperty(stmt.getProperties(),
DataProperty.DEFAULT_HDD_DATA_PROPERTY);
- PropertyAnalyzer.analyzeReplicationNum(properties,
FeConstants.default_replication_num);
+ Short replicationNum =
PropertyAnalyzer.analyzeReplicationNum(properties,
FeConstants.default_replication_num);
Review comment:
replicationNum here is useless, replication value is got from
`partitionInfo.getReplicationNum(),`
And, you haven't check unpartitioned table, and number of bucket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
