imay commented on a change in pull request #246: Colocate Join (#245)
URL: https://github.com/apache/incubator-doris/pull/246#discussion_r231428989
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -2712,6 +2744,13 @@ public void addPartition(Database db, String tableName,
AddPartitionClause addPa
// here we check partition's properties
singlePartitionDesc.analyze(rangePartitionInfo.getPartitionColumns().size(),
null);
+ if (olapTable.getColocateTable() != null) {
+ short tableReplicationNum =
rangePartitionInfo.idToReplicationNum.entrySet().iterator().next().getValue();
+ if (tableReplicationNum !=
singlePartitionDesc.getReplicationNum()) {
+
ErrorReport.reportDdlException(ErrorCode.ERR_COLOCATE_TABLE_MUST_SAME_REPLICAT_NUM,
partitionName);
+ }
+ }
+
Review comment:
I think there is need to check bucket number.
same to ` modifyPartition`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
