imay commented on a change in pull request #246: Colocate Join (#245)
URL: https://github.com/apache/incubator-doris/pull/246#discussion_r231483011
##########
File path:
fe/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java
##########
@@ -44,9 +45,15 @@ public void analyze(Analyzer analyzer) throws
AnalysisException {
throw new AnalysisException("Properties is not set");
}
- if
(!Catalog.getCurrentCatalog().getAuth().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ALTER)) {
+ if (properties.size() == 1 &&
properties.containsKey(KEY_COLOCATE_WITH)) {
Review comment:
Why? If one user have ALTER privilege for two tables, it's reasonable that
he could make these two tables colocated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
