jamesge commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269979808
 
 

 ##########
 File path: src/brpc/details/health_check.h
 ##########
 @@ -0,0 +1,33 @@
+// Copyright (c) 2014 Baidu, Inc.
+// 
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// 
+//     http://www.apache.org/licenses/LICENSE-2.0
+// 
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Authors: Ge,Jun ([email protected])
+//          Jiashun Zhu([email protected])
+
+#ifndef _HEALTH_CHECK_H
+#define _HEALTH_CHECK_H
+
+#include "brpc/socket_id.h"
+#include "brpc/periodic_task.h"
+#include "bvar/bvar.h"
+#include "brpc/socket.h"
+
+namespace brpc {
+
+// Start health check for socket id after delay_ms.
+void StartHealthCheckWithDelayMS(SocketId id, int64_t delay_ms);
 
 Review comment:
   WithDelayMs可以去掉,参数已经带这个意思了。说明下delay_ms取什么值时才会delay才是重要的。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to