jamesge commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269019674
##########
File path: src/brpc/socket.cpp
##########
@@ -92,6 +96,15 @@ DEFINE_int32(connect_timeout_as_unreachable, 3,
"times *continuously*, the error is changed to ENETUNREACH which "
"fails the main socket as well when this socket is pooled.");
+DEFINE_string(health_check_path, "", "Http path of health check call."
+ "By default health check succeeds if server can be connected. If this"
+ "flag is set, health check is completed not only when server can be"
+ "connected but also an additional http call succeeds indicated by this"
+ "flag and FLAGS_health_check_timeout_ms");
Review comment:
if server can be connected -> if the server is connectable
not only...but also的意思是说hc不仅会在连接建立时完成，还会在http call成功时完成，也就是说会多次完成,
这个并不是正确的意思吧。应该说成，If this flag is set, health check is not completed until a
http call to the path succeeds within -health_check_timeout_ms.
让我来写我还会加句提示" (to make sure the server functions well)"
另外一个细节是FLAGS_xxx是程序内部的说法，对于用户自然是-xxx而不是FLAGS_xxx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
