jamesge commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269020754
##########
File path: src/brpc/socket.cpp
##########
@@ -92,6 +96,15 @@ DEFINE_int32(connect_timeout_as_unreachable, 3,
"times *continuously*, the error is changed to ENETUNREACH which "
"fails the main socket as well when this socket is pooled.");
+DEFINE_string(health_check_path, "", "Http path of health check call."
+ "By default health check succeeds if server can be connected. If this"
+ "flag is set, health check is completed not only when server can be"
+ "connected but also an additional http call succeeds indicated by this"
+ "flag and FLAGS_health_check_timeout_ms");
+DEFINE_int32(health_check_timeout_ms, 500, "Timeout of health check."
+ "If FLAGS_health_check_path is empty, it means timeout of connect."
+ "Otherwise it means timeout of app health check call.");
Review comment:
The timeout for both establishing the connection and the http call to
-health_check_path over the connection
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
