jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268953327
########## File path: src/brpc/controller.h ########## @@ -118,6 +118,8 @@ friend int StreamCreate(StreamId*, Controller&, const StreamOptions*); friend int StreamAccept(StreamId*, Controller&, const StreamOptions*); friend void policy::ProcessMongoRequest(InputMessageBase*); friend void policy::ProcessThriftRequest(InputMessageBase*); +friend class OnAppHealthCheckDone; +friend class HealthCheckManager; Review comment: 用PrivateAccessor，不要加friend class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
