jamesge commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269483082
##########
File path: src/brpc/socket.cpp
##########
@@ -881,7 +861,7 @@ int Socket::SetFailed(int error_code, const char*
error_fmt, ...) {
if (_health_check_interval_s > 0) {
GetOrNewSharedPart()->circuit_breaker.MarkAsBroken();
PeriodicTaskManager::StartTaskAt(
- new HealthCheckTask(id()),
+ new HealthCheckTask(id(), &s_vars->nhealthcheck),
butil::milliseconds_from_now(GetOrNewSharedPart()->
Review comment:
封装一个接口代替这个调用，health_check.h只对外暴露一个函数接口，HealthCheckTask是实现。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
