On Tuesday, July 7, 2015 at 3:30:59 PM UTC-7, Birunthan Mohanathas wrote: > On 7 July 2015 at 15:02, Mike Hommey <m...@glandium.org> wrote: > > On Tue, Jul 07, 2015 at 11:52:12PM +0300, smaug wrote: > >> until the tools (and poiru) are run and make the code follow Mozilla > >> coding style. > > > > Assuming you're talking about clang-format, that doesn't take care > > about anything else than whitespaces. > > I have a Clang tool to add the 'a' prefix, but it can be easily > modified to drop the prefix should we decide to do so.
I'm not a huge fan of the 'aFoo' style, but I am a huge fan of consistency. So if we want to change the style guide we should update our codebase, and I don't think we can reasonably do that automatically without introducing shadowing issues. Additionally I don't spend 50% of my time reviewing, so I'd say my opinion here (meh to aFoo) is less important. It's not an undue burden for me to include an aPrefix and if we have static analysis to check for it that would make it even less of an issue. re: refactoring, I suppose that could be an argument against the aPrefix, but then again various IDE's make this a bit easier (including Eclipse, which I believe roc is a user of). -e _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
