On Tue, Jul 7, 2015 at 3:02 PM, Mike Hommey <m...@glandium.org> wrote:

> On Tue, Jul 07, 2015 at 11:52:12PM +0300, smaug wrote:
> > On 07/07/2015 11:45 PM, Milan Sreckovic wrote:
> > >
> > >Removing the style guide for “prefix function arguments with a” will
> not preclude people from naming a variable aFoo.  At least the current
> style guide precludes people from naming non-function arguments that way,
> albeit indirectly.
> > >
> > >I’m trying to understand the possible outcomes of this particular
> conversation:
> > >
> > >a) Nothing happens.  We leave a prefix in the style guide, some code
> ignores it, some follows it.
> > until the tools (and poiru) are run and make the code follow Mozilla
> coding style.
>
> Assuming you're talking about clang-format, that doesn't take care
> about anything else than whitespaces.
>

poiru built tools to automatically make all the adjustments that we
prescribe in the style guide, and has been iteratively running them on
various modules (thanks poiru!), so we should assume that whatever style we
pick for the style guide will end up applying to all/most of our code in
the not-too-distant future.

This is a good thing - specifying things in the style guide but keeping the
tree inconsistent on the grounds of "when in Rome" is the wrong approach.
This was discussed to death in various threads already, and the conclusion
is that we are actively moving towards a unified style in Gecko and SM.

bholley
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to