Just my opinion on this, I don't care enough to argue it more than this;
rm -rf <any directory> in response to configure, by default, is *not*
expected, or reasonable behaviour. Rather than having an environment
variable to turn this off, it should be the other way round. I can see
people getting caught out by this, even one of the students I was
mentoring stored things in the objdir (against my advice, mind, but all
the same).
I think it's a reasonable statement to say that people don't expect a
configure script to delete things, especially things it may not have
created. Either there should be a more reliable clean-up method, or I
don't think this should be default behaviour.
--Chris
On 01/04/2013 19:24, Gregory Szorc wrote:
On 4/1/2013 11:00 AM, Jeff Hammel wrote:
On 03/29/2013 06:01 PM, Gregory Szorc wrote:
<snip/>
I highly recommend against defining MOZ_OBJDIR in terms of relative
paths. You're implicitly creating a dependency on cwd. This is handy
in a few use cases but it's a giant foot gun. Instead, do something
like |mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-firefox|.
I have MOZ_OBJDIR (generally) = @TOPSRCDIR@/../obj-browser ; is this
unsupported? I generally don't like putting the objdir as a subdir as
the srcdir for various unimportant reasons not worth discussing on list.
This is supported and should work fine. MOZ_OBJDIR is anchored to
TOPSRCDIR, which should always resolve as an absolute path.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
