On Sat, 22 Aug 2026 03:22:36 GMT, Alexander Matveev <[email protected]> 
wrote:

>> - Added `--app-resources`.
>> 
>> Specification:
>> 
>> --app-resources
>> 
>>     A File.pathSeparator separated list of paths
>> 
>>     Additional application files and directories to copy into the
>>     application resources directory.
>> 
>>     This option may be specified multiple times.
>> 
>>     Destination:
>>         Windows: application image root
>>         Linux: application image lib directory
>>         macOS: Contents/Resources
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8388795: Add --app-resources CLI option to copy files and directories into 
> the application resources directory [v2]

Changes requested by asemenyuk (Reviewer).

src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties
 line 160:

> 158: \          This option can be used more than once.\n\
> 159: \          Destination:\n\
> 160: \              Linux: application image lib directory

Wouldn't it be better to explicitly specify where the content will be copied 
and eliminate the "Destination:" section:

\          A colon-separated list of paths to files and/or directories\n\
\          to add to the application's "lib" directory.\n\
\          If a file from --app-resources conflicts with one from\n\
          --app-content, the file from --app-resources is used.\n\
\          This option can be used more than once.\n\

-------------

PR Review: https://git.openjdk.org/jdk/pull/32474#pullrequestreview-5000800394
PR Review Comment: https://git.openjdk.org/jdk/pull/32474#discussion_r3836729355

Reply via email to