On Thu, 20 Aug 2026 23:55:07 GMT, Alexey Semenyuk <[email protected]> wrote:

>> - Added `--app-resources`.
>> 
>> Specification:
>> 
>> --app-resources
>> 
>>     A File.pathSeparator separated list of paths
>> 
>>     Additional application files and directories to copy into the
>>     application resources directory.
>> 
>>     This option may be specified multiple times.
>> 
>>     Destination:
>>         Windows: application image root
>>         Linux: application image lib directory
>>         macOS: Contents/Resources
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> test/jdk/tools/jpackage/share/AppContentAndResourcesTest.java line 472:
> 
>> 470:     @FunctionalInterface
>> 471:     private interface ContentFactory {
>> 472:         Content create(JPackageCommand cmd, AppFilesOption option);
> 
> I think `AppFilesOption option` is excessive. `boolean 
> srcRootMustBeResourcesDir` should be sufficient.

It contains more parameters such as delimeter, so lets keep this class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32474#discussion_r3834756009

Reply via email to