On Sat, 22 Aug 2026 01:43:00 GMT, Alexander Matveev <[email protected]> wrote:
>> test/jdk/tools/jpackage/share/AppContentTest.java line 472: >> >>> (failed to retrieve contents of file, check the PR for context) >> I think `AppFilesOption option` is excessive. `boolean >> srcRootMustBeResourcesDir` should be sufficient. > > It contains more parameters such as delimeter, so lets keep this class. I'm not suggesting removing the class itself. It looks good. I'm suggesting changing the signature of the `ContentFactory.create()` method from `ContentFactory.create(JPackageCommand cmd, AppFilesOption option)` to `ContentFactory.create(JPackageCommand cmd, boolean srcRootMustBeResourcesDir)`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32474#discussion_r3836694150
