On Sat, 22 Aug 2026 03:22:36 GMT, Alexander Matveev <[email protected]> 
wrote:

>> - Added `--app-resources`.
>> 
>> Specification:
>> 
>> --app-resources
>> 
>>     A File.pathSeparator separated list of paths
>> 
>>     Additional application files and directories to copy into the
>>     application resources directory.
>> 
>>     This option may be specified multiple times.
>> 
>>     Destination:
>>         Windows: application image root
>>         Linux: application image lib directory
>>         macOS: Contents/Resources
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8388795: Add --app-resources CLI option to copy files and directories into 
> the application resources directory [v2]

test/jdk/tools/jpackage/share/AppImageFillOrderTest.java line 157:

> 155:                 .addInitializer(cmd -> inputs.addTo(cmd, resourcesFirst))
> 156:                 .addInstallVerifier(inputs::verify)
> 157:                 .run();

We probably don't want to install these packages in the test environment, where 
test packages can be installed; we can do all verification in an unpacked 
image, and installation doesn't improve coverage. To avoid package installation 
and limit testing to unpacking only, use `.run(Action.CREATE_AND_UNPACK)` 
instead of `.run()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32474#discussion_r3836712303

Reply via email to