On Sun, 28 Sep 2025 08:53:08 GMT, Jaikiran Pai <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update close() to use "terminate" consistently.
>
> test/jdk/java/lang/Process/ProcessCloseTest.java line 70:
>
>> 68: JAVA_HOME = System.getProperty("JAVA_HOME");
>> 69: String classPath = System.getProperty("test.class.path");
>> 70: return List.of(JAVA_HOME + "/bin/java", "-cp", classPath,
>> ProcessCloseTest.class.getName());
>
> The method name says `setupJavaEXE()`. Was this line here expected to
> conditionally use `.exe` suffix for Windows, like some other tests do?
The .exe extension is not necessary or expected. The method name EXE is short
for execution.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2388155700
