On Sun, 28 Sep 2025 08:50:40 GMT, Jaikiran Pai <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update close() to use "terminate" consistently.
>
> test/jdk/java/lang/Process/ProcessCloseTest.java line 68:
>
>> 66: String JAVA_HOME = System.getProperty("test.jdk");
>> 67: if (JAVA_HOME == null)
>> 68: JAVA_HOME = System.getProperty("JAVA_HOME");
>
> Should we instead just rely on the standard `java.home` property instead of
> these conditionals? i.e. `System.getProperty("java.home")`?
The fallback to JAVA_HOME facilitates running the test from the command line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2388143167
