On Mon, 22 Sep 2025 22:25:59 GMT, Roger Riggs <[email protected]> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing >> of streams and ensuring the termination of the process is the responsibility >> of the caller. The `Process.close()` method provides a clear and obvious way >> to ensure all the streams are closed and the process terminated. >> >> The try-with-resources statement is frequently used to open streams and >> ensure they are closed on exiting the block. By implementing >> `AutoClosable.close()` the completeness of closing the streams and process >> termination can be done by try-with-resources. >> >> The actions of the `close()` method are to close each stream and destroy the >> process if it has not terminated. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Update close() to use "terminate" consistently. test/jdk/java/lang/Process/ProcessCloseTest.java line 509: > 507: } > 508: /** > 509: * Test AutoCloseable for the process and out, in, and err streams. I think this test method comment would need an update. It doesn't match the test method implementation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2385727786
