On Mon, 29 Sep 2025 14:11:25 GMT, Roger Riggs <[email protected]> wrote:
>> test/jdk/java/lang/Process/ProcessCloseTest.java line 68:
>>
>>> 66: String JAVA_HOME = System.getProperty("test.jdk");
>>> 67: if (JAVA_HOME == null)
>>> 68: JAVA_HOME = System.getProperty("JAVA_HOME");
>>
>> Should we instead just rely on the standard `java.home` property instead of
>> these conditionals? i.e. `System.getProperty("java.home")`?
>
> The fallback to JAVA_HOME facilitates running the test from the command line.
Thank you Roger for clarifying. The current form is fine with me.
>> test/jdk/java/lang/Process/ProcessCloseTest.java line 70:
>>
>>> 68: JAVA_HOME = System.getProperty("JAVA_HOME");
>>> 69: String classPath = System.getProperty("test.class.path");
>>> 70: return List.of(JAVA_HOME + "/bin/java", "-cp", classPath,
>>> ProcessCloseTest.class.getName());
>>
>> The method name says `setupJavaEXE()`. Was this line here expected to
>> conditionally use `.exe` suffix for Windows, like some other tests do?
>
> The .exe extension is not necessary or expected. The method name EXE is short
> for execution.
Noted
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2391672759
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2391674464
