On Fri, 10 Oct 2025 16:03:38 GMT, Lance Andersen <[email protected]> wrote:
>> This PR adds support for the upcoming JDBC 4.5 MR which provides the
>> following updates to the JDBC specification:
>>
>> - Deprecate SQLPermission for removal
>> - Enhance the Blob/Clob/Array/SQLXML/NClob interfaces to extend/support
>> AutoClosable
>> - Add the SQL types DECFLOAT, JSON to Types.Java and JDBCType.java
>> - Add the quoted identifier methods that **were added previously to the
>> Statement interface in JDK 9** to the Connection interface
>> - It is the exact same verbiage & default methods used when these methods
>> were added to the Statement interface
>> - Clarify the Timestamp::hashCode method which incorrectly indicates that
>> nanos are not used when calculating the hash
>>
>> Tiers 1-3 have been run
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Doc clean up based on feedback
test/jdk/java/sql/testng/test/sql/ConnectionTests.java line 36:
> 34: import static org.testng.Assert.assertEquals;
> 35:
> 36: public class ConnectionTests extends BaseTest {
Suggestion: `ConnectionTests` -> `ConnectionTest`, also use JUnit instead of
TestNG.
test/jdk/java/sql/testng/test/sql/ConnectionTests.java line 39:
> 37:
> 38: protected StubConnection conn;
> 39: protected static String maxIdentifier;
You could use `protected static final String MAX_IDENTIFIER = "a".repeat(128);`
test/jdk/java/sql/testng/test/sql/ConnectionTests.java line 59:
> 57: * single quote to two single quotes
> 58: */
> 59:
Suggestion: Move empty line before the method comment.
test/jdk/java/sql/testng/test/sql/ConnectionTests.java line 72:
> 70: public void test01() throws SQLException {
> 71: conn.enquoteLiteral(null);
> 72:
Suggestion: remove empty line (also in following methods).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2421052230
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2421043792
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2421084553
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2421055485
