On Fri, 17 Oct 2025 22:12:25 GMT, Lance Andersen <[email protected]> wrote:
>> This PR adds support for the upcoming JDBC 4.5 MR which provides the
>> following updates to the JDBC specification:
>>
>> - Deprecate SQLPermission for removal
>> - Enhance the Blob/Clob/Array/SQLXML/NClob interfaces to extend/support
>> AutoClosable
>> - Add the SQL types DECFLOAT, JSON to Types.Java and JDBCType.java
>> - Add the quoted identifier methods that **were added previously to the
>> Statement interface in JDK 9** to the Connection interface
>> - It is the exact same verbiage & default methods used when these methods
>> were added to the Statement interface
>> - Clarify the Timestamp::hashCode method which incorrectly indicates that
>> nanos are not used when calculating the hash
>>
>> Tiers 1-3 have been run
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor wordsmithing based on approved CSR feedback
src/java.sql/share/classes/java/sql/Connection.java line 1831:
> 1829:
> 1830: /**
> 1831: * Retrieves whether {@code identifier} is a simple SQL identifier.
Have you consider having the first line just say that it returns true if an
identifier is a simple identifier? I'm asking because "Retrieves" is confusing
here. There is no leeway in the specification to allow for different
implementations to have a different outcome. No issue with driver
implementations that consult with the database to get a result but it doesn't
change the outcome.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2442916052
