On Fri, 17 Oct 2025 22:12:25 GMT, Lance Andersen <[email protected]> wrote:
>> This PR adds support for the upcoming JDBC 4.5 MR which provides the
>> following updates to the JDBC specification:
>>
>> - Deprecate SQLPermission for removal
>> - Enhance the Blob/Clob/Array/SQLXML/NClob interfaces to extend/support
>> AutoClosable
>> - Add the SQL types DECFLOAT, JSON to Types.Java and JDBCType.java
>> - Add the quoted identifier methods that **were added previously to the
>> Statement interface in JDK 9** to the Connection interface
>> - It is the exact same verbiage & default methods used when these methods
>> were added to the Statement interface
>> - Clarify the Timestamp::hashCode method which incorrectly indicates that
>> nanos are not used when calculating the hash
>>
>> Tiers 1-3 have been run
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor wordsmithing based on approved CSR feedback
src/java.sql/share/classes/java/sql/Connection.java line 1722:
> 1720:
> 1721: /**
> 1722: * Returns a SQL identifier. If {@code identifier} is a simple SQL
> identifier:
"simple SQL identifier" is used in several places, is there anywhere that (at
least first) usages could link to see the definition of this?
src/java.sql/share/classes/java/sql/package-info.java line 176:
> 174: * </UL>
> 175: *
> 176: * <h3>{@code java.sql} and {@code javax.sql} Features Introduced in
> the JDBC 4.5 API</h3>
The title is consistent with the other updates but I'm wondering why it hasn't
been switched to "module java.sql".
src/java.sql/share/classes/java/sql/package-info.java line 347:
> 345: *
> 346: * <ul>
> 347: * <li><a href="https://jcp.org/en/jsr/detail?id=221";>JDBC 4.5
> Specification</a>
I realize we continue to maintain the JDBC spec in the JCP but I'm trying to
understand why it hasn't been subsumed. It's not really a question for this PR
but it's puzzling that we continues to be tracked when it's not a standalone
technology and the java.sql module is not upgradable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2442793018
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2442793752
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2442794798
