On Fri, 17 Oct 2025 22:12:25 GMT, Lance Andersen <[email protected]> wrote:
>> This PR adds support for the upcoming JDBC 4.5 MR which provides the
>> following updates to the JDBC specification:
>>
>> - Deprecate SQLPermission for removal
>> - Enhance the Blob/Clob/Array/SQLXML/NClob interfaces to extend/support
>> AutoClosable
>> - Add the SQL types DECFLOAT, JSON to Types.Java and JDBCType.java
>> - Add the quoted identifier methods that **were added previously to the
>> Statement interface in JDK 9** to the Connection interface
>> - It is the exact same verbiage & default methods used when these methods
>> were added to the Statement interface
>> - Clarify the Timestamp::hashCode method which incorrectly indicates that
>> nanos are not used when calculating the hash
>>
>> Tiers 1-3 have been run
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor wordsmithing based on approved CSR feedback
src/java.sql/share/classes/java/sql/Connection.java line 1722:
> 1720:
> 1721: /**
> 1722: * Returns a SQL identifier. If {@code identifier} is a simple SQL
> identifier:
I realize the method name and description come from Statement.enquoteIdentifier
but neither do justice to what this method actually does. Have you considered
replacing the first sentence with something clearly to say what the method does?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2442906241
