On Fri, 21 Feb 2025 17:10:24 GMT, Viktor Klang <[email protected]> wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 146:
>
>> 144: * and invoke other {@linkplain ForkJoinTask ForkJoinTasks}. Delayed
>> 145: * actions become <em>enabled</em> and behave as ordinary submitted
>> 146: * tasks when their delays elapse. schedule methods return
>
> Suggestion:
>
> * tasks when their delays elapse. Scheduling methods return
done
> test/jdk/java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java
> line 50:
>
>> 48: var future = new CompletableFuture<>().orTimeout(12,
>> TimeUnit.HOURS);
>> 49: future.completeExceptionally(new RuntimeException("This is
>> fine"));
>> 50: while (delayer.getDelayedTaskCount() != 0) {
>
> Might be good to start the test case asserting that the delayed task count is
> 0 (so there's no interference).
Thanks, done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r1966506690
PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r1966506368
