On Fri, 21 Feb 2025 16:28:15 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>
> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line
> 2840:
>
>> 2838: Canceller(Future<?> f) { this.f = f; }
>> 2839: public void accept(Object ignore, Throwable ex) {
>> 2840: if (f != null)
>
> @DougLea Does it make sense to create a Canceller with a `null` `f`-parameter?
The usual j.u.c answer: it is never null now, but if there were ever a case in
which it were, it's a no-op.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23702#discussion_r1966502091
