On Wed, 11 Jan 2023 09:13:27 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update src/java.base/share/classes/java/io/ObjectStreamConstants.java >> >> Co-authored-by: Andrey Turbanov <turban...@gmail.com> >> - Clean up ObjectStreamConstants > > src/java.base/share/classes/java/io/ObjectStreamConstants.java line 139: > >> 137: * First wire handle to be assigned. >> 138: */ >> 139: static int BASE_WIRE_HANDLE = 0x7e0000; > > Isn't it a part of public API? You shouldn't rename such things in cleanup > PRs. > > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/ObjectStreamConstants.html#baseWireHandle Oops. Thanks for spotting this. Fixed. ------------- PR: https://git.openjdk.org/jdk/pull/11848
