On Wed, 11 Jan 2023 15:31:22 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Code in java.io contains many legacy constructs and semantics not >> recommended including: >> >> * C-style array declaration >> * Unnecessary visibility >> * Redundant keywords in interfaces (e.g. public, static) >> * Non-standard naming for constants >> * Javadoc typos >> * Missing final declaration >> >> These should be fixed as a sanity effort. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Convert field to static and revert copyright year It is easy to fall into the trap "I'll just fix everything I see now that I am here anyway" which it appears I have done in this case. Even though I had the best intentions, I think we should close this PR and replace it with several smaller ones that focus on a specific problem. ------------- PR: https://git.openjdk.org/jdk/pull/11848
