Cole-Greer commented on code in PR #3456:
URL: https://github.com/apache/tinkerpop/pull/3456#discussion_r3455048992
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/Translator.java:
##########
@@ -48,6 +48,11 @@ public enum Translator {
*/
DOTNET("DotNet", DotNetTranslateVisitor::new),
+ /**
+ * Translates to gremlin-dotnet with parameterized GValue wrapping for
variables.
+ */
+ DOTNET_PARAMETERIZE("DotNetParameterize", name -> new
DotNetTranslateVisitor(name, true)),
Review Comment:
I opted to remove the enum for parameterized dotnet. It's a niche enough use
case which really only exists for dotnet feature test generation. I don't think
there's a need to confuse the enums with this new option now, generate.groovy
can manually construct the parameterized translator.
We can revisit the enum later if demand arises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
