spmallette commented on code in PR #3456:
URL: https://github.com/apache/tinkerpop/pull/3456#discussion_r3422794249
##########
gremlin-dotnet/build/generate.groovy:
##########
@@ -132,6 +147,43 @@ radishGremlinFile.withWriter('UTF-8') { Writer writer ->
}
writer.writeLine(' };\n')
+ // Generate parameterized translations
+ writer.writeLine(
+ ' private static readonly IDictionary<string,
List<Func<GraphTraversalSource, IDictionary<string, object>,ITraversal>>>
ParameterizedTranslations = \n' +
+ ' new Dictionary<string,
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>>\n' +
+ ' {')
+
+ gremlins.each { k,v ->
Review Comment:
i know this is just a internal utility script, but maybe we should
encapsulate some of this duplicate logic?? i could envision an the accident of
changing one but not the other and that regex seems complicated enough for one
to get out of sync with the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
