spmallette commented on code in PR #3456:
URL: https://github.com/apache/tinkerpop/pull/3456#discussion_r3422734247
##########
gremlin-dotnet/build/generate.groovy:
##########
@@ -132,6 +147,43 @@ radishGremlinFile.withWriter('UTF-8') { Writer writer ->
}
writer.writeLine(' };\n')
+ // Generate parameterized translations
Review Comment:
The PR description points this out:
> .NET parameterize design: .NET is the only driver that parameterizes at
the translator level (a second generated dotnet_parameterize translation set)
rather than at runtime, because it's the only variant that is both statically
typed and exposes strongly-typed GValue overloads—so value-vs-GValue is a
compile-
time overload choice.
I think i'd like to see comments here along with the code explaining the
purpose. We will need to remind ourselves someday why this is the way it is, to
say nothing of agents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
