spmallette commented on code in PR #3456:
URL: https://github.com/apache/tinkerpop/pull/3456#discussion_r3422772694
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/Translator.java:
##########
@@ -48,6 +48,11 @@ public enum Translator {
*/
DOTNET("DotNet", DotNetTranslateVisitor::new),
+ /**
+ * Translates to gremlin-dotnet with parameterized GValue wrapping for
variables.
+ */
+ DOTNET_PARAMETERIZE("DotNetParameterize", name -> new
DotNetTranslateVisitor(name, true)),
Review Comment:
as mentioned elsewhere, this is odd enough that it deserves more javadoc
explaining usage/why. Probably extends to its `DOTNET` counterpart.
as a side note, this feels unfortunate to our `Translator` enum. from a
discoverability perspective, the API looks asymetric. a user might wonder how
they get parameters with `JAVASCRIPT` given this naming. Thoughts on other
things we could do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
