spmallette commented on code in PR #3456:
URL: https://github.com/apache/tinkerpop/pull/3456#discussion_r3422783823
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/Translator.java:
##########
@@ -48,6 +48,11 @@ public enum Translator {
*/
DOTNET("DotNet", DotNetTranslateVisitor::new),
+ /**
+ * Translates to gremlin-dotnet with parameterized GValue wrapping for
variables.
+ */
+ DOTNET_PARAMETERIZE("DotNetParameterize", name -> new
DotNetTranslateVisitor(name, true)),
Review Comment:
As a separate point, assuming there aren't other options, shouldn't there be
some tests for this translator. I don't see any:
https://github.com/apache/tinkerpop/blob/GValueFollowupTP4/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/language/translator/GremlinTranslatorTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
