DanielLeens commented on issue #13080: URL: https://github.com/apache/seatunnel/issues/13080#issuecomment-6595077424
Hi @sharpca, thanks for the follow-up. On the CI status: `action_required` on the `Build` check does not mean the run is waiting for maintainer approval. For apache/seatunnel the build for a PR runs in the contributor's fork, and the PR's `Build` check only reports that fork run. On #13081 the check reports "Workflow run detection failed", and `sharpca/seatunnel` has no workflow runs at all, so there is no gate a maintainer can approve here. The only `action_required` run on the apache side is `Label-when-reviewed`, a review-labeling workflow that does not build or test anything. To get CI running: 1. Open the **Actions** tab of your fork and enable GitHub Actions if it shows the enable button. 2. Select the **Build** workflow, click **Run workflow** and pick the PR branch (or push an empty commit). 3. The PR's `Build` check adopts the fork run within about 15 minutes. One gap I found while checking the CLI paths on `dev`, which #13081 does not touch yet: `--checkpoint-history-status` is parsed in `ClientExecuteCommand` with `CheckpointStatus.valueOf(clientCommandArgs.getCheckpointHistoryStatus().toUpperCase())`. `CheckpointStatus` has `IN_PROGRESS` and `FAILED`, so under `tr-TR` an input such as `failed` becomes `FAİLED` and the command reports "Unsupported checkpoint history status". This is the same class of CLI enum argument as the issue title, so it would be good to fix it in #13081 with `Locale.ROOT` and add a matching Turkish-locale assertion. If you prefer to keep #13081 as-is, please say so and it can be tracked separately. Other default-locale conversions I saw in `seatunnel-core` (for example the Flink checkpoint mode and time characteristic switches in `AbstractFlinkRuntimeEnvironment`) read job config values rather than CLI arguments, so they are outside this issue and do not need to block #13081. Once the fork build has run, the detailed review continues on #13081 itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
