sharpca commented on issue #13080:
URL: https://github.com/apache/seatunnel/issues/13080#issuecomment-6555096209
Thanks. #13081 covers every conversion in the table.
- **Spark `--deploy-mode`** — `SparkDeployModeConverter` matches the value
with `Locale.ROOT`
- **Flink `--deploy-mode`** — `FlinkDeployModeConverter` uses `Locale.ROOT`
- **Flink `--target`** — `FlinkMasterTargetConverter` (`--master` /
`--target`) uses `Locale.ROOT`
- **`-pt` / `--plugin-type` in `seatunnel-starter`** — both
`ConnectorCheckCommandArgs` and `MetadataExportCommandArgs` use `Locale.ROOT`
- **`DeployMode.from(String)`** — now returns `Optional.empty()` for a
`null` argument instead of throwing, and lower-cases with `Locale.ROOT`
The dash-to-underscore mapping is kept, so `run-application` and
`yarn-session` still resolve to `RUN_APPLICATION` and `YARN_SESSION` under any
locale.
**Turkish locale tests** — `DeployModeTest`,
`SparkCommandArgsConverterTest`, `FlinkCommandArgsConverterTest` and
`ConnectorCheckCommandArgsTest` each parse the arguments with `new Locale("tr",
"TR")` as the default locale and restore the previous default afterwards.
`DeployModeTest` also asserts `from(null)` returns empty.
One note: the workflows on #13081 are still waiting for a maintainer to
approve them (`action_required`), so no test has run in CI yet. Everything
above was verified locally on JDK 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
