SEZ9 commented on issue #13080: URL: https://github.com/apache/seatunnel/issues/13080#issuecomment-6567343104
Thanks @sharpca for the detailed breakdown. From your description, the PR addresses each item in the report — the Spark/Flink `--deploy-mode` and `--target` conversions, `-pt` / `--plugin-type` handling, and the `null` argument in `DeployMode.from(String)` — along with Turkish-locale tests that fail against the unpatched sources. That sounds like the right direction, and I'll take a closer look at the changes themselves on the PR. Since the workflows there haven't run yet and everything so far has been verified locally on JDK 17, could you ping here once CI has run so we can confirm the results? We can continue the detailed review on the PR and close this issue once it lands. <!-- streview-comment:2201 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
