SEZ9 commented on issue #13080: URL: https://github.com/apache/seatunnel/issues/13080#issuecomment-6552719375
Thanks for the detailed report and the reproduction steps. Since you're willing to submit a PR, please go ahead. It would be good for the fix to cover all the conversions listed in your table (the Spark and Flink `--deploy-mode` / `--target` handling in `seatunnel-spark-starter-common` and `seatunnel-flink-starter-common`, and the `-pt` handling in `seatunnel-starter`) so the case conversion no longer depends on the JVM default locale, and to also handle the `null` argument case in `DeployMode.from(String)` that you mentioned. A unit test that runs these conversions under a Turkish default locale would help prevent a regression. <!-- streview-comment:2189 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
