Jackie-Jiang commented on code in PR #16165:
URL: https://github.com/apache/pinot/pull/16165#discussion_r2164882227
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##########
@@ -236,6 +237,17 @@ public static RoaringBitmap
getValidDocIdFromServerMatchingCrc(String tableNameW
LOGGER.warn(message);
continue;
}
+
+ // skipping servers which are not in READY state. The bitmaps would be
inconsistent when
+ // server is NOT READY as UPDATING segments might be updating the ONLINE
segments
+ if
(!validDocIdsBitmapResponse.getServerStatus().equals(ServiceStatus.Status.GOOD))
{
Review Comment:
(MAJOR) This can cause `NPE` during upgrade. Check if it is not null, then
perform this check. Same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
