krishan1390 commented on code in PR #16165:
URL: https://github.com/apache/pinot/pull/16165#discussion_r2163454919
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -534,15 +547,18 @@ public ValidDocIdsBitmapResponse
downloadValidDocIdsBitmap(
if (validDocIdSnapshot == null) {
String msg = String.format(
"Found that validDocIds is missing while fetching validDocIds for
table %s segment %s while "
- + "reading the validDocIds with validDocIdType %s",
- tableNameWithType, segmentDataManager.getSegmentName(),
validDocIdsType);
+ + "reading the validDocIds with validDocIdType %s",
tableNameWithType,
+ segmentDataManager.getSegmentName(), validDocIdsType);
LOGGER.warn(msg);
throw new WebApplicationException(msg, Response.Status.NOT_FOUND);
}
-
byte[] validDocIdsBytes =
RoaringBitmapUtils.serialize(validDocIdSnapshot);
return new ValidDocIdsBitmapResponse(segmentName,
indexSegment.getSegmentMetadata().getCrc(),
- finalValidDocIdsType, validDocIdsBytes);
+ finalValidDocIdsType, validDocIdsBytes,
_serverInstance.getInstanceDataManager().getInstanceId(),
+ serverStatus);
+ } catch (Exception e) {
+ LOGGER.error("Failed to get validDocIds for table {}: {}",
tableNameWithType, e.getMessage());
+ return null;
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
