krishan1390 commented on code in PR #16165:
URL: https://github.com/apache/pinot/pull/16165#discussion_r2163454383
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -525,6 +530,14 @@ public ValidDocIdsBitmapResponse downloadValidDocIdsBitmap(
String.format("Table %s segment %s is not a immutable segment",
tableNameWithType, segmentName),
Response.Status.BAD_REQUEST);
}
+ ServiceStatus.Status status =
ServiceStatus.getServiceStatus(_instanceId);
+ String serverStatus = "";
+ if (status.equals(ServiceStatus.Status.GOOD)) {
+
_serverMetrics.addMeteredGlobalValue(ServerMeter.READINESS_CHECK_OK_CALLS, 1);
Review Comment:
removed
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java:
##########
@@ -96,6 +102,14 @@ protected SegmentConversionResult convert(PinotTaskConfig
pinotTaskConfig, File
.build();
}
+ if (!validDocIdsBitmapResponse.getServerStatus().equals("OK")) {
Review Comment:
moved to MinionTaskUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
