klsince commented on code in PR #16165:
URL: https://github.com/apache/pinot/pull/16165#discussion_r2165056602
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3235,6 +3235,44 @@ public Map<String, List<String>>
getServerToSegmentsMap(String tableNameWithType
return serverToSegmentsMap;
}
+ /**
+ * Get the servers to segments map for which servers are ONLINE in external
view for those segments in IDEAL STATE
+ */
+ public Map<String, List<String>> getServerToOnlineSegmentsMapFromEV(String
tableNameWithType,
Review Comment:
We may extract a common method for getServerToOnlineSegmentsMapFromEV() and
getServerToSegmentsMap() above, as the major difference is where to get
segment's status, i.e. IS vs. EV.
(oops, found this just got merged. If this makes sense ^, can be done in
separate PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
