deepthi912 commented on code in PR #16165:
URL: https://github.com/apache/pinot/pull/16165#discussion_r2163020448


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3235,6 +3235,35 @@ public Map<String, List<String>> 
getServerToSegmentsMap(String tableNameWithType
     return serverToSegmentsMap;
   }
 
+  /**
+   * Get the servers to segments map for which servers are ONLINE in external 
view for those segments in IDEAL STATE
+   */
+  public Map<String, List<String>> getOnlineServerToSegmentsMap(String 
tableNameWithType) {

Review Comment:
   Yes, this is needed for checking status of each segment here in external 
view rather than in Ideal state as some segments will be in BAD state. Server 
status is still needed because some of the UPDATING segments can change the bit 
map of ONLINE segments, so it is better to wait until server is in READY state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to