xiaoxiang781216 commented on a change in pull request #2222:
URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r524082178
##########
File path: include/stdio.h
##########
@@ -190,15 +190,21 @@ int snprintf(FAR char *buf, size_t size,
int sscanf(FAR const char *buf, FAR const IPTR char *fmt, ...);
int scanf(FAR const IPTR char *fmt, ...);
-int vasprintf(FAR char **ptr, FAR const IPTR char *fmt, va_list ap);
+int vasprintf(FAR char **ptr, FAR const IPTR char *fmt, va_list ap)
+ printflike(2, 0);
int vfprintf(FAR FILE *stream, FAR const IPTR char *fmt,
- va_list ap);
-int vfscanf(FAR FILE *stream, FAR const IPTR char *fmt, va_list ap);
-int vprintf(FAR const IPTR char *fmt, va_list ap);
+ va_list ap)
+ printflike(2, 0);
Review comment:
merge to previous line
##########
File path: arch/xtensa/include/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: include/nuttx/compiler_stdint.h
##########
@@ -69,6 +69,9 @@ typedef __INTMAX_TYPE__ _intmax_t;
#if defined(__UINTMAX_TYPE__)
typedef __UINTMAX_TYPE__ _uintmax_t;
#endif
+#if defined(__SIZE_TYPE__)
+typedef __SIZE_TYPE__ _size_t;
Review comment:
merge into one patch?
##########
File path: arch/x86/include/i486/types.h
##########
@@ -45,6 +45,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/arm/include/types.h
##########
@@ -30,6 +30,7 @@
****************************************************************************/
#include <nuttx/config.h>
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/risc-v/include/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/hc/include/hcs12/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -389,7 +390,7 @@ wifi_osi_funcs_t g_wifi_osi_funcs =
._nvs_erase_key = esp_nvs_erase_key,
._get_random = esp_get_random,
._get_time = esp_get_time,
- ._random = esp_random,
+ ._random = esp_random_ulong,
Review comment:
should w change _ranom prototype to uint32_t (void)?
##########
File path: arch/avr/include/avr/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/x86_64/include/intel64/types.h
##########
@@ -30,6 +30,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/avr/include/avr32/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/renesas/include/m16c/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: include/stdio.h
##########
@@ -190,15 +190,21 @@ int snprintf(FAR char *buf, size_t size,
int sscanf(FAR const char *buf, FAR const IPTR char *fmt, ...);
int scanf(FAR const IPTR char *fmt, ...);
-int vasprintf(FAR char **ptr, FAR const IPTR char *fmt, va_list ap);
+int vasprintf(FAR char **ptr, FAR const IPTR char *fmt, va_list ap)
+ printflike(2, 0);
int vfprintf(FAR FILE *stream, FAR const IPTR char *fmt,
- va_list ap);
-int vfscanf(FAR FILE *stream, FAR const IPTR char *fmt, va_list ap);
-int vprintf(FAR const IPTR char *fmt, va_list ap);
+ va_list ap)
+ printflike(2, 0);
+int vfscanf(FAR FILE *stream, FAR const IPTR char *fmt, va_list ap)
+ printflike(2, 0);
+int vprintf(FAR const IPTR char *fmt, va_list ap)
+ printflike(1, 0);
int vscanf(FAR const IPTR char *fmt, va_list ap);
int vsnprintf(FAR char *buf, size_t size, FAR const IPTR char *fmt,
- va_list ap);
-int vsprintf(FAR char *buf, FAR const IPTR char *fmt, va_list ap);
+ va_list ap)
+ printflike(3, 0);
Review comment:
merge to previous line
##########
File path: arch/misoc/include/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/sim/include/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
if we include compiler_stdint.h, why not remove all from line 68?
##########
File path: arch/renesas/include/rx65n/types.h
##########
@@ -29,6 +29,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/or1k/include/types.h
##########
@@ -45,6 +45,7 @@
****************************************************************************/
#include <nuttx/config.h>
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/z80/include/z80/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/z80/include/z8/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/renesas/include/sh1/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/sim/include/inttypes.h
##########
@@ -44,7 +44,7 @@
* Pre-processor Definitions
****************************************************************************/
-#if defined(__APPLE__)
+#if defined(CONFIG_HOST_MACOS)
Review comment:
why not use __APPLE__?
##########
File path: arch/z16/include/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/mips/include/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
why include compiler_stdint.h
##########
File path: arch/z80/include/ez80/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/hc/include/hc12/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
##########
File path: arch/z80/include/z180/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
same question as sim
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
