yamt commented on a change in pull request #2222:
URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r520634422
##########
File path: arch/arm/src/lpc214x/lpc214x_serial.c
##########
@@ -89,7 +90,7 @@ static int up_attach(struct uart_dev_s *dev);
static void up_detach(struct uart_dev_s *dev);
static int up_interrupt(int irq, void *context, void *arg);
static int up_ioctl(struct file *filep, int cmd, unsigned long arg);
-static int up_receive(struct uart_dev_s *dev, uint32_t *status);
+static int up_receive(struct uart_dev_s *dev, unsigned int *status);
Review comment:
"Right now uint32_t is used everywhere" is a false assumption.
please see the interface definition here:
https://github.com/apache/incubator-nuttx/blob/c79bda6e4f305c153a117e7ad454ec4e69610d69/include/nuttx/serial/serial.h#L206-L211
also, there is a precedent:
https://github.com/apache/incubator-nuttx/commit/e2aad9c05a085abb9d58b1faa70a631be5e8d89f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
