v01d commented on a change in pull request #2222:
URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r520650306
##########
File path: arch/arm/src/lpc214x/lpc214x_serial.c
##########
@@ -89,7 +90,7 @@ static int up_attach(struct uart_dev_s *dev);
static void up_detach(struct uart_dev_s *dev);
static int up_interrupt(int irq, void *context, void *arg);
static int up_ioctl(struct file *filep, int cmd, unsigned long arg);
-static int up_receive(struct uart_dev_s *dev, uint32_t *status);
+static int up_receive(struct uart_dev_s *dev, unsigned int *status);
Review comment:
And actually I was also curious because I'm used to get a warning from
QtCreator's clangbackend whenever I use putreg32, even if I pass uint32_t, it
complains that I'm casting an integer to a pointer, which it understands it is
not the same size. I always understood this as clangbackend not getting the
correct flags, but at the same time I wondered if we should be using uintptr_t
in some places instead of uint32_t*. Anyway, just wondering about it, not
suggesting any changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
