yamt commented on a change in pull request #2222:
URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r523297170
##########
File path: arch/sim/include/types.h
##########
@@ -69,13 +69,41 @@ typedef unsigned char _uint8_t;
typedef signed short _int16_t;
typedef unsigned short _uint16_t;
+#if defined(__INT32_TYPE__)
+typedef __INT32_TYPE__ _int32_t;
+#else
typedef signed int _int32_t;
+#endif
+
+#if defined(__UINT32_TYPE__)
+typedef __UINT32_TYPE__ _uint32_t;
+#else
typedef unsigned int _uint32_t;
+#endif
+#if defined(__INT64_TYPE__)
+typedef __INT64_TYPE__ _int64_t;
+#else
typedef signed long long _int64_t;
+#endif
+
+#if defined(__UINT64_TYPE__)
+typedef __UINT64_TYPE__ _uint64_t;
+#else
typedef unsigned long long _uint64_t;
+#endif
#define __INT64_DEFINED
+#if defined(__INTMAX_TYPE__)
+typedef __INTMAX_TYPE__ _intmax_t;
+#define __INTMAX_DEFINED
Review comment:
a quick googling suggested:
https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/ms235402(v=vs.100)?redirectedfrom=MSDN#advanced-annotations
i don't know if `__xxx_TYPE__` is available there.
anyway, if we decide particular boards are always compiled with a particular
compiler, we can simplify them later.
i don't feel it needs to be done in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
